Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3701
Part of #3520
Rationale for this change
See issue description #3701.
What changes are included in this PR?
Update the
take_run
function to do the below1 Take physical_indices for the given logical indices.
2 Run encode the physical_indices while keeping track of physical indices that needs to be taken.
3 take values from run_array.values based on physical indices from the step 2.
4 Build a new run array using run_ends from step 2 and values from step 3.
The performance of benchmark
primitive_take_run
has improved by approx 15%Benchmark result
Are there any user-facing changes?
No