Reduce PrimitiveArray::try_unary codegen #3619
Merged
+0
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
try_for_each_valid_idx
already has a fast path for the case of no nulls, and so this special case is just resulting in additional codegen.I have confirmed that the cast_kernels and arithmetic_kernels benchmarks show no performance regressions (and actually show performance improvements in some cases).
What changes are included in this PR?
Are there any user-facing changes?