Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce PrimitiveArray::try_unary codegen #3619

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

try_for_each_valid_idx already has a fast path for the case of no nulls, and so this special case is just resulting in additional codegen.

I have confirmed that the cast_kernels and arithmetic_kernels benchmarks show no performance regressions (and actually show performance improvements in some cases).

What changes are included in this PR?

Are there any user-facing changes?

Verified

This commit was signed with the committer’s verified signature.
pdabelf5 Paul Abel
@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 27, 2023
@tustvold tustvold requested a review from viirya January 29, 2023 11:52
@tustvold tustvold merged commit 266e2cf into apache:master Jan 29, 2023
@ursabot
Copy link

ursabot commented Jan 29, 2023

Benchmark runs are scheduled for baseline = 02c695f and contender = 266e2cf. 266e2cf is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants