Fix nullif null count (#3579) #3590
Conversation
| let t = !b; | ||
| valid_count += t.count_ones() as usize; | ||
| null_count += t.count_zeros() as usize; |
There was a problem hiding this comment.
Don't need to compensate remainder bits?
There was a problem hiding this comment.
Nope, we instead exploit the property that the remainder bits will always be 0 (and therefore the corresponding bits in t will be 1)
|
Benchmark runs are scheduled for baseline = b826657 and contender = b35e179. b35e179 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3579
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?