-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ArrayAccessor, Iterator, Extend and benches for string run builder #3583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arrow
Changes to the arrow crate
parquet
Changes to the parquet crate
labels
Jan 22, 2023
askoa
changed the title
Ree array more
Add ArrayAccessor, Iterator and look up using binary search for REE Array
Jan 22, 2023
Benchmark for building REE Array
|
askoa
changed the title
Add ArrayAccessor, Iterator and look up using binary search for REE Array
Add ArrayAccessor, Iterator, Extend and benches for string run builder
Jan 24, 2023
Will make a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #3520
Rationale for this change
See issue description
What changes are included in this PR?
Built on top of yet to be merged (1/21/2023) PRs #3553 and #3534. Hence marking this PR draft.
Extend
for thePrimitiveRunBuilder
andGenericByteRunBuilder
TypedRunArray
RunArrayIter
andArrayAccessor
forTypedRunArray
StringRunBuilder
Are there any user-facing changes?
Users will get new features for RunArray.
No breaking changes.