Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DataTypeLayout for LargeList #3503

Merged
merged 2 commits into from
Jan 11, 2023
Merged

Fix DataTypeLayout for LargeList #3503

merged 2 commits into from
Jan 11, 2023

Conversation

viirya
Copy link
Member

@viirya viirya commented Jan 10, 2023 •
edited
Loading

Which issue does this PR close?

Closes #.

Rationale for this change

DataTypeLayout for LargeList types uses i32 for byte width incorrectly.

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 10, 2023
@tustvold
Copy link
Contributor

Perhaps there should be some tests for this

@viirya
Copy link
Member Author

viirya commented Jan 11, 2023

Added some tests for primitive types.

viirya
viirya commented Jan 11, 2023
View reviewed changes
Copy link
Member Author

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For nested types like list, I'm thinking how to test it is better.

tustvold
tustvold approved these changes Jan 11, 2023
View reviewed changes
arrow-array/src/types.rs
@@ -803,4 +805,46 @@ mod tests {
let value = IntervalYearMonthType::make_value(-1, -2);
assert_eq!(IntervalYearMonthType::to_months(value), -14);
}

fn test_layout<T: ArrowPrimitiveType>() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tustvold tustvold merged commit 55c87c1 into apache:master Jan 11, 2023
@ursabot
Copy link

ursabot commented Jan 11, 2023

Benchmark runs are scheduled for baseline = ddba53b and contender = 55c87c1. 55c87c1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viirya @tustvold @ursabot