Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove azurite test exception #3497

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Remove azurite test exception #3497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions object_store/src/azure/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -965,10 +965,8 @@ mod tests {

#[tokio::test]
async fn azure_blob_test() {
let use_emulator = env::var("AZURE_USE_EMULATOR").is_ok();
let integration = maybe_skip_integration!().build().unwrap();
// Azurite doesn't support listing with spaces - https://github.com/localstack/localstack/issues/6328
put_get_delete_list_opts(&integration, use_emulator).await;
put_get_delete_list_opts(&integration, false).await;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need skip_list_with_spaces in put_get_delete_list_opts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least historically localstack also had issues with spaces, although this might have been fixed by now... I'll double check when I get a chance

list_uses_directories_correctly(&integration).await;
list_with_delimiter(&integration).await;
rename_and_copy(&integration).await;
Expand Down