Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more dictionary value type support to build_compare #3466

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Add more dictionary value type support to build_compare #3466

merged 1 commit into from
Jan 6, 2023

Conversation

viirya
Copy link
Member

@viirya viirya commented Jan 5, 2023

Which issue does this PR close?

Closes #3465.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

viirya
viirya commented Jan 5, 2023
View reviewed changes
arrow-ord/src/ord.rs
key_type_lhs,
left,
right,
)?,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave decimal type out here and will do it in other PR.

tustvold
tustvold reviewed Jan 5, 2023
View reviewed changes
arrow-ord/src/ord.rs
@@ -263,6 +263,73 @@ pub fn build_compare(
UInt16 => cmp_dict_primitive::<UInt16Type>(key_type_lhs, left, right)?,
UInt32 => cmp_dict_primitive::<UInt32Type>(key_type_lhs, left, right)?,
UInt64 => cmp_dict_primitive::<UInt64Type>(key_type_lhs, left, right)?,
Float32 => cmp_dict_primitive::<Float32Type>(key_type_lhs, left, right)?,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could use downcast_primitive to simplify this, perhaps something for a follow up PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, sounds good.

@viirya viirya merged commit 9403ef5 into apache:master Jan 6, 2023
@ursabot
Copy link

ursabot commented Jan 6, 2023

Benchmark runs are scheduled for baseline = acefeef and contender = 9403ef5. 9403ef5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@viirya viirya mentioned this pull request Jan 7, 2023
Merged
@tustvold tustvold added the arrow Changes to the arrow crate label Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold left review comments

@Dandandan Dandandan Dandandan approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more dictionary value type support to build_compare
4 participants
@viirya @ursabot @Dandandan @tustvold