Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: column_name based index access for RecordBatch and StructArray #3458

Merged
merged 2 commits into from
Jan 7, 2023
Merged

feat: column_name based index access for RecordBatch and StructArray #3458

merged 2 commits into from
Jan 7, 2023

Conversation

askoa
Copy link
Contributor

@askoa askoa commented Jan 5, 2023

Which issue does this PR close?

Part of #3448

What changes are included in this PR?

The column_name based access is added for RecordBatch and StructArray

Are there any user-facing changes?

Yes, users will get new ways to access columns in RecordBatch and StructArray.

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 5, 2023
Copy link
Member

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

IIUC this doesn't preclude us from also implementing Index<i64> for StructArray, in case we ever wanted to implement that for arrays to get values / scalars. We could do something similar to serde-json. So this doesn't seem to have any drawbacks.

@tustvold tustvold merged commit ca7ea59 into apache:master Jan 7, 2023
@ursabot
Copy link

ursabot commented Jan 7, 2023

Benchmark runs are scheduled for baseline = d325ad2 and contender = ca7ea59. ca7ea59 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@askoa askoa deleted the column-name branch January 12, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants