Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Remove parquet build script #3257

Merged
merged 2 commits into from
Dec 2, 2022

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Dec 2, 2022

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the parquet Changes to the parquet crate label Dec 2, 2022
@jimexist
Copy link
Member

jimexist commented Dec 2, 2022

wonder why was there a build script in the first place?

@tustvold
Copy link
Contributor Author

tustvold commented Dec 2, 2022

Potentially this wasn't always possible, I'm not sure when concat was added

@tustvold tustvold requested a review from alamb December 2, 2022 18:49
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alamb alamb changed the title Remove parquet build script Minor: Remove parquet build script Dec 2, 2022
@tustvold tustvold merged commit f6bd9b5 into apache:master Dec 2, 2022
@ursabot
Copy link

ursabot commented Dec 2, 2022

Benchmark runs are scheduled for baseline = 74b174c and contender = f6bd9b5. f6bd9b5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants