Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move decimal constants from arrow-data to arrow-schema crate #3177

Merged
merged 4 commits into from
Nov 24, 2022

Conversation

mbrobbel
Copy link
Contributor

@mbrobbel mbrobbel commented Nov 24, 2022

Rationale for this change

When building something with arrow-schema it's useful to have these constants without having to depend on arrow-data.

What changes are included in this PR?

This change moves the following decimal related constants from the arrow-data to the arrow-schema crate:

  • MAX_DECIMAL_FOR_EACH_PRECISION
  • MIN_DECIMAL_FOR_EACH_PRECISION
  • DECIMAL128_MAX_PRECISION
  • DECIMAL128_MAX_SCALE
  • DECIMAL256_MAX_PRECISION
  • DECIMAL256_MAX_SCALE
  • DECIMAL_DEFAULT_SCALE

Are there any user-facing changes?

Yes, this is a breaking change. It requires updating use statements in dependent crates. We could pub use these constants from the arrow-data crate to prevent this.

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 24, 2022
arrow/src/row/mod.rs Outdated Show resolved Hide resolved
Co-authored-by: Raphael Taylor-Davies <[email protected]>
@tustvold tustvold merged commit 22deab0 into apache:master Nov 24, 2022
@ursabot
Copy link

ursabot commented Nov 24, 2022

Benchmark runs are scheduled for baseline = 3e2d39e and contender = 22deab0. 22deab0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants