Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add binary_mut and try_binary_mut #3144

Merged
merged 7 commits into from
Nov 30, 2022
Merged

Add binary_mut and try_binary_mut #3144

merged 7 commits into from
Nov 30, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Nov 19, 2022

Which issue does this PR close?

Closes #3143.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 19, 2022
tustvold
tustvold reviewed Nov 21, 2022
View reviewed changes
arrow/src/compute/kernels/arity.rs
a: PrimitiveArray<T>,
b: &PrimitiveArray<T>,
op: F,
) -> std::result::Result<
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned on #3134 I think this Result should be the other way round

viirya
viirya commented Nov 28, 2022
View reviewed changes
arrow/src/compute/kernels/arity.rs
/// This function gives error if the arrays have different lengths.
/// This function gives error of original [`PrimitiveArray`] `a` if it is not a mutable
/// primitive array.
pub fn binary_mut<T, F>(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, I will leave this only and remove _mut kernels.

@viirya viirya changed the title Add add_mut and add_checked_mut Add binary_mut and try_binary_mut Nov 29, 2022
@tustvold tustvold merged commit 961e114 into apache:master Nov 30, 2022
@ursabot
Copy link

ursabot commented Nov 30, 2022

Benchmark runs are scheduled for baseline = 989ab8d and contender = 961e114. 961e114 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

This was referenced May 24, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doki23 doki23 doki23 left review comments

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add binary_mut and try_binary_mut
4 participants
@viirya @ursabot @tustvold @doki23