Replace remaining _generic temporal kernels with _dyn kernels #3046
Conversation
| array: A, | ||
| dt: &DataType, | ||
| ) -> Result<Int32Array> | ||
| fn month_internal<T>(array: &PrimitiveArray<T>) -> Result<Int32Array> |
There was a problem hiding this comment.
It occurs to me that these _internal methods are no longer necessary as they now have the same signature as the non _internal methods
| name: &str, | ||
| op: F, | ||
| ) -> Result<Int32Array> | ||
| fn time_fraction_dyn<F>(array: &dyn Array, name: &str, op: F) -> Result<ArrayRef> |
There was a problem hiding this comment.
I wonder if more of the kernels could be implemented using this, possibly something for a future PR
|
Benchmark runs are scheduled for baseline = 6057cf7 and contender = 232fccc. 232fccc is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Yea, I will do some cleanup later for this and probably for #3046 (comment). |
Which issue does this PR close?
Closes #3004.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?