Support building comparator for dictionaries of primitive integer values #2673
Conversation
|
cc @sunchao |
|
This is needed to extend dictionary support coverage of sorting kernel. |
arrow/src/array/ord.rs
Outdated
| @@ -101,6 +126,27 @@ where | |||
| }) | |||
| } | |||
|
|
|||
| macro_rules! cmp_dict_primitive { | |||
There was a problem hiding this comment.
could we use a method here? seems the only reason is because of returning Err. I think we can just panic here since the dictionary key type can't be anything else.
There was a problem hiding this comment.
Changed it to a generic function.
viirya
force-pushed
the
compare_dict_primitive
branch
from
79229f3 to
a7964c8
Compare
|
Go build has some issue. It should be unrelated. |
|
Thanks. |
|
Benchmark runs are scheduled for baseline = c25d16e and contender = df4906d. df4906d is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #2672.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?