Canonicalize filesystem paths in user-facing APIs (#2370) #2371
Conversation
tustvold
force-pushed
the
local-file-system-relative-root
branch
from
e1eefbb to
88a9408
Compare
tustvold
changed the title
| async fn relative_paths() { | ||
| LocalFileSystem::new_with_prefix(".").unwrap(); | ||
| LocalFileSystem::new_with_prefix("..").unwrap(); | ||
| LocalFileSystem::new_with_prefix("../..").unwrap(); |
There was a problem hiding this comment.
I guess this should be ok (../.. will exist) -- as long as the test isn't run in the root of the file system 😆
|
Benchmark runs are scheduled for baseline = 77c814c and contender = b55e3b1. b55e3b1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #2370
Rationale for this change
Users expect to be able to pass arbitrary paths to
LocalFileSystem::new_with_prefixorPath::from_filesystem_pathand for it to work correctly. This stopped working following #2269 as we stopped canonicalizing paths.This PR therefore strikes a middle-ground, we canonicalize paths passed to the external interfaces, ensuring the above works. However, we otherwise continue to preserve symlinks, etc... whilst navigating the filesystem as part of object storage operation, thereby ensuring symlinks behave "as expected".
What changes are included in this PR?
Are there any user-facing changes?