Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update create-tarball.sh and verify_release.sh script to skip object_store #2339

Merged
merged 3 commits into from
Aug 18, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Aug 5, 2022

Draft as I am not sure this is what we want to be doing here -- see #2338 for discussion

Re #2382

Which issue does this PR close?

Closes #2338

Rationale for this change

object_store is going to be released separately from arrow / parquet / arrow_flight / parquet_derive so it should not be in the tarballs

What changes are included in this PR?

change to release scripts

Are there any user-facing changes?

no

@alamb alamb marked this pull request as draft August 5, 2022 20:30
@tustvold
Copy link
Contributor

Is this waiting for something?

@alamb
Copy link
Contributor Author

alamb commented Aug 12, 2022

Sorry -- it is waiting for me to test it (manually) -- namely I want to test the entire cycle of "create a tarball" and then "run the verification script" -- I was thinking I would do that in connection with the #2382 release

@alamb alamb marked this pull request as ready for review August 18, 2022 20:34
@alamb
Copy link
Contributor Author

alamb commented Aug 18, 2022

This PR is basically the same as @tustvold approved, the only thing I changed was to restore the commented out lines in 1ba0355

@alamb alamb merged commit 7ce6ba4 into apache:master Aug 18, 2022
@alamb alamb deleted the alamb/update_release_scripts branch August 18, 2022 20:47
@ursabot
Copy link

ursabot commented Aug 18, 2022

Benchmark runs are scheduled for baseline = dacd354 and contender = 7ce6ba4. 7ce6ba4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb added the development-process Related to development process of arrow-rs label Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arrow 20.0.0 official release candidiate also has object_store crate code in it
3 participants