Add add_dyn for DictionaryArray support #1951
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1951 +/- ##
=======================================
Coverage 83.47% 83.48%
=======================================
Files 221 221
Lines 57054 57106 +52
=======================================
+ Hits 47626 47675 +49
- Misses 9428 9431 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Thank you @viirya -- I went through this PR and it looks good to me.
I am surprised at the amount of code required for this but I tried and couldn't really figure out any better way (as the macros are basically implementing all the type dispatch to then call add).
| .take_iter_unchecked($right.keys_iter()) | ||
| }; | ||
|
|
||
| let result = left_iter |
| fn test_primitive_array_add_dyn_dict() { | ||
| let key_builder = PrimitiveBuilder::<Int8Type>::new(3); | ||
| let value_builder = PrimitiveBuilder::<Int32Type>::new(2); | ||
| let mut builder = PrimitiveDictionaryBuilder::new(key_builder, value_builder); |
There was a problem hiding this comment.
I think it would be good to have at least one null value (via append_null) to make sure that works correctly
I have tried to use nested macro with repetition (the |
There are lots of places in our code where we map |
|
Thanks @alamb @martin-g @HaoYang670 |
Which issue does this PR close?
Closes #1950.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?