-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use littleendian arrow files for projection_should_work
#1573
Conversation
fn projection_should_work() { | ||
// complementary to the previous test | ||
let testdata = crate::util::test_util::arrow_test_data(); | ||
let paths = vec![ | ||
"generated_interval", | ||
"generated_datetime", | ||
// "generated_map", Err: Last offset 872415232 of Utf8 is larger than values length 52 (https://github.com/apache/arrow-rs/issues/859) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also due to bigendian offsets. So I uncomment it too.
Codecov Report
@@ Coverage Diff @@
## master #1573 +/- ##
==========================================
- Coverage 82.87% 82.87% -0.01%
==========================================
Files 193 193
Lines 55304 55304
==========================================
- Hits 45835 45834 -1
- Misses 9469 9470 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing, this was an oversight of me! |
Thanks @tustvold @Dandandan ! |
Which issue does this PR close?
Closes #1548.
Rationale for this change
Currently by enabling
force_validate
, the testprojection_should_work
fails.It is because the arrow files used in the test is bigendian, but currently the IPC reader doesn't translate big endian offsets (#859). As that's a known issue, I change the test to use littleendian arrow files, and add a comment there to explain the reason.
What changes are included in this PR?
Are there any user-facing changes?