Support the length kernel on Binary Array
#1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rewrite unary_offset using macro Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1465 +/- ##
==========================================
+ Coverage 82.70% 82.71% +0.01%
==========================================
Files 187 187
Lines 54169 54255 +86
==========================================
+ Hits 44801 44878 +77
- Misses 9368 9377 +9
Continue to review full report at Codecov.
|
|
@alamb Could you please help to review? |
alamb
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
This is very nicely done @HaoYang670 🏅
Thank you and sorry for the review delay
|
|
||
| #[test] | ||
| fn length_test_large_binary() -> Result<()> { | ||
| let value: Vec<&[u8]> = vec![b"zero", &[0xff, 0xf8], b"two"]; |
viirya
reviewed
Mar 24, 2022
arrow/src/compute/kernels/length.rs
Outdated
| @@ -94,18 +111,20 @@ where | |||
| .downcast_ref::<GenericStringArray<O>>() | |||
| .unwrap(); | |||
| let bits_in_bytes = O::from_usize(8).unwrap(); | |||
| unary_offsets_string::<O, _>(array, T::DATA_TYPE, |x| x * bits_in_bytes) | |||
| unary_offsets!(array, T::DATA_TYPE, |x| x * bits_in_bytes) | |||
| } | |||
|
|
|||
| /// Returns an array of Int32/Int64 denoting the number of bytes in each string in the array. | |||
There was a problem hiding this comment.
Suggested change
| /// Returns an array of Int32/Int64 denoting the number of bytes in each string in the array. | |
| /// Returns an array of Int32/Int64 denoting the number of bytes in each string/binary in the array. |
viirya
reviewed
Mar 24, 2022
arrow/src/compute/kernels/length.rs
Outdated
| @@ -115,13 +134,15 @@ pub fn length(array: &dyn Array) -> Result<ArrayRef> { | |||
|
|
|||
| /// Returns an array of Int32/Int64 denoting the number of bits in each string in the array. | |||
simplify the way to get offsets. No performance penalty Signed-off-by: remzi <[email protected]>
alamb
reviewed
Mar 24, 2022
| // this is a 30% improvement over iterating over u8s and building OffsetSize, which | ||
| // justifies the usage of `unsafe`. | ||
| let slice: &[O] = &unsafe { offsets.typed_data::<O>() }[$array.offset()..]; | ||
| let slice = $array.value_offsets(); |
|
Thanks @HaoYang670 and @viirya |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1464.
Rationale for this change
The
lengthkernel can work withBinaryArraynow!.What changes are included in this PR?
lengthandbit_lengthfunctions for Binary Arrayunary_offsetsusing macroMicro benchmark
No obvious performance penalty.
Are there any user-facing changes?
Some private functions' APIs are changed.