Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support RecordBatch::remove_column() and Schema::remove_field() #4952

Closed
Folyd opened this issue Oct 19, 2023 · 2 comments · Fixed by #4959
Closed

Support RecordBatch::remove_column() and Schema::remove_field() #4952

Folyd opened this issue Oct 19, 2023 · 2 comments · Fixed by #4959
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted

Comments

@Folyd
Copy link
Contributor

Folyd commented Oct 19, 2023

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Arrow C++ implementation support removes column and field for RecordBatch and Schema respectively, arrow-rs doesn't have such APIs.

Describe the solution you'd like

Add RecordBatch::remove_column() and Schema::remove_field(), similar to C++:
@Folyd Folyd added the enhancement Any new improvement worthy of a entry in the changelog label Oct 19, 2023
@tustvold
Copy link
Contributor

This should be a relatively straightforward task and can likely be modeled on the existing project methods

@Folyd Folyd mentioned this issue Oct 19, 2023
Merged
tustvold added a commit to tustvold/arrow-rs that referenced this issue Oct 20, 2023
@tustvold
Add SchemaBuilder::remove (apache#4952)
b333d96
@tustvold tustvold mentioned this issue Oct 20, 2023
Merged
tustvold added a commit that referenced this issue Oct 20, 2023
@tustvold
Add SchemaBuilder::remove (#4952) (#4964)
03d0505
@tustvold tustvold added the arrow Changes to the arrow crate label Nov 2, 2023
@tustvold
Copy link
Contributor

tustvold commented Nov 2, 2023

label_issue.py automatically added labels {'arrow'} from #4964

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Field::remove(), Schema::remove(), and RecordBatch::remove_column() APIs Folyd/arrow-rs
2 participants
@tustvold @Folyd