Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datum is not exported as part of arrow (it is only exported in arrow_array) #4780

Closed
alamb opened this issue Sep 5, 2023 · 3 comments · Fixed by #4791
Closed

Datum is not exported as part of arrow (it is only exported in arrow_array) #4780

alamb opened this issue Sep 5, 2023 · 3 comments · Fixed by #4791
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@alamb
Copy link
Contributor

alamb commented Sep 5, 2023

Very similar to #4779 but I think this is more serious

Describe the bug
The newly introduced Datum is not exported in arrow even though it is part of the signature of the new compute kernels such as https://docs.rs/arrow/latest/arrow/compute/kernels/cmp/fn.eq.html

This means that to use some of the functions in the arrow crate, a user has to use arrow_array directly, which is inconvenient, or use a deprecated method.

To Reproduce
Search for Datum in arrow: https://docs.rs/arrow/latest/arrow/index.html?search=datum

It only appears in https://docs.rs/arrow-array/46.0.0/arrow_array/trait.Datum.html

Expected behavior
A trait used in the arrow crate API should also be exported in that same crate.

Additional context
Found while updating https://github.com/influxdata/influxdb_iox/pull/8577

@alamb alamb added the bug label Sep 5, 2023
@tustvold tustvold added enhancement Any new improvement worthy of a entry in the changelog and removed bug labels Sep 5, 2023
@tustvold
Copy link
Contributor

tustvold commented Sep 5, 2023

I'm unclear on why this is considered serious, most users won't need to reference the trait, but I do agree we should fix this

@alamb
Copy link
Contributor Author

alamb commented Sep 5, 2023

I'm unclear on why this is considered serious

I think it is more serious than #4779; I don't think it is particularly serious overall -- more like inconvenient / a rough edge

This means you can't use the new compute kernels for scalars without also importing arrow_array which is annoying

tustvold added a commit to tustvold/arrow-rs that referenced this issue Sep 7, 2023
tustvold added a commit to tustvold/arrow-rs that referenced this issue Sep 7, 2023
tustvold added a commit that referenced this issue Sep 7, 2023
* Re-export array crate root (#4780) (#4779)

* Clippy
@tustvold tustvold added the arrow Changes to the arrow crate label Sep 18, 2023
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'arrow'} from #4791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants