Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datum Based Comparison Kernels #4596

Closed
tustvold opened this issue Jul 30, 2023 · 3 comments · Fixed by #4701
Closed

Datum Based Comparison Kernels #4596

tustvold opened this issue Jul 30, 2023 · 3 comments · Fixed by #4701
Assignees
@tustvold
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

arrow-ord currently provides methods of the form

  • lt_eq_dyn_bool_scalar
  • lt_eq_dyn
  • lt_eq_dyn_ut8_scalar

This is extremely verbose and hard to use

Describe the solution you'd like

I would like kernels defined in terms of the new Datum abstraction

Describe alternatives you've considered

Additional context
@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Jul 30, 2023
@tustvold tustvold self-assigned this Aug 14, 2023
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 15, 2023
@tustvold
Datum based comparison kernels (apache#4596)
a567e16
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 15, 2023
@tustvold
Datum based comparison kernels (apache#4596)
f72839a
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 15, 2023
@tustvold
Datum based comparison kernels (apache#4596)
095a625
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 15, 2023
@tustvold
Datum based comparison kernels (apache#4596)
8cce942
@tustvold tustvold mentioned this issue Aug 15, 2023
Merged
tustvold added a commit that referenced this issue Aug 18, 2023
@tustvold
Datum based comparison kernels (#4596) (#4701)
8bbb5c1 
* Datum based comparison kernels (#4596)

* Clippy

* More clippy

* Even more clippy

* Further clippy

* Format

* Use take kernel for scalar evaluation

* Clippy

* Review feedback

* Use AnyDictionaryArray
@tustvold
Copy link
Contributor Author

label_issue.py automatically added labels {'parquet'} from #4701

@tustvold tustvold added parquet Changes to the parquet crate arrow Changes to the arrow crate labels Aug 21, 2023
@tustvold
Copy link
Contributor Author

label_issue.py automatically added labels {'arrow'} from #4701

@tustvold
Copy link
Contributor Author

label_issue.py automatically added labels {'arrow-flight'} from #4701

@tustvold tustvold added the arrow-flight Changes to the arrow-flight crate label Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tustvold tustvold

Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Datum based comparison kernels (#4596) tustvold/arrow-rs
1 participant
@tustvold