Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent CSV Inference and Parsing DateTime Handling #4129

Closed
tustvold opened this issue Apr 25, 2023 · 2 comments · Fixed by #4133
Closed

Inconsistent CSV Inference and Parsing DateTime Handling #4129

tustvold opened this issue Apr 25, 2023 · 2 comments · Fixed by #4133
Assignees
@tustvold
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Following #3746 the CSV schema inference infers datetime strings as Timestamps, not Date64, as this was incorrect #3744.

However, the CSV reader still uses datetime_regex for Date64 columns, which is incorrect.

Following #3794 the timestamp parsing logic has got a whole lot more sophisticated, and it is unclear how to support arbitrary format strings with it.

Describe the solution you'd like

Given this functionality has been broken since #3746 and nobody has noticed, and no tests failed, I think we should just remove it

Describe alternatives you've considered

Additional context
@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Apr 25, 2023
@tustvold tustvold mentioned this issue Apr 25, 2023
Closed
@tustvold tustvold self-assigned this Apr 25, 2023
tustvold added a commit to tustvold/arrow-rs that referenced this issue Apr 25, 2023
@tustvold
Cleanup CSV schema inference (apache#4129) (apache#4130)
71ff348
@tustvold tustvold mentioned this issue Apr 25, 2023
Merged
tustvold added a commit to tustvold/arrow-rs that referenced this issue Apr 25, 2023
@tustvold
Cleanup CSV schema inference (apache#4129) (apache#4130)
3ace8c8
tustvold added a commit to tustvold/arrow-rs that referenced this issue Apr 25, 2023
@tustvold
Cleanup CSV schema inference (apache#4129) (apache#4130)
0b3be62
tustvold added a commit that referenced this issue Apr 27, 2023
@tustvold
Cleanup CSV schema inference (#4129) (#4130) (#4133)
9fa8125 
* Cleanup CSV schema inference (#4129) (#4130)

* Update tests

* Update parquet-fromcsv
@tustvold
Copy link
Contributor Author

tustvold commented May 5, 2023

label_issue.py automatically added labels {'parquet'} from #4133

@tustvold tustvold added the parquet Changes to the parquet crate label May 5, 2023
@tustvold
Copy link
Contributor Author

tustvold commented May 5, 2023

label_issue.py automatically added labels {'arrow'} from #4133

@tustvold tustvold added the arrow Changes to the arrow crate label May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tustvold tustvold

Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup CSV schema inference (#4129) (#4130) tustvold/arrow-rs
1 participant
@tustvold