Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async JSON reader #4043

Closed
waynexia opened this issue Apr 10, 2023 · 3 comments · Fixed by #4046
Closed

Async JSON reader #4043

waynexia opened this issue Apr 10, 2023 · 3 comments · Fixed by #4046
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@waynexia
Copy link
Member

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

like #78, async reader for JSON files is also useful sometimes.

Describe the solution you'd like

Add async Read support to arrow_json crate.

Describe alternatives you've considered

Additional context

We encountered a situation where only an asynchronous reader was available recently. It is difficult to bridge between synchronous and asynchronous interfaces, causing inconvenience.
@waynexia waynexia added the enhancement Any new improvement worthy of a entry in the changelog label Apr 10, 2023
@tustvold
Copy link
Contributor

tustvold commented Apr 10, 2023 •
edited
Loading

This was added in #3479

In particular https://docs.rs/arrow-json/latest/arrow_json/struct.RawDecoder.html

Edit: Perhaps we might make this more discoverable? Any thoughts welcome

tustvold added a commit to tustvold/arrow-rs that referenced this issue Apr 10, 2023
@tustvold
Document Async decoder usage (apache#4043) (#78)
d14e9ae
tustvold added a commit to tustvold/arrow-rs that referenced this issue Apr 10, 2023
@tustvold
Document Async decoder usage (apache#4043) (#78)
233eb82
tustvold added a commit to tustvold/arrow-rs that referenced this issue Apr 10, 2023
@tustvold
Document Async decoder usage (apache#4043) (#78)
250d95b
@tustvold tustvold mentioned this issue Apr 10, 2023
Merged
@tustvold
Copy link
Contributor

I've created #4046 to better document this functionality, PTAL

tustvold added a commit to tustvold/arrow-rs that referenced this issue Apr 10, 2023
@tustvold
Document Async decoder usage (apache#4043) (#78)
caa43fd
tustvold added a commit that referenced this issue Apr 11, 2023
@tustvold
Document Async decoder usage (#4043) (#78) (#4046)
884ab4e 
* Document Async decoder usage (#4043) (#78)

* Review feedback

* Review feedback
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'arrow'} from #4046

@tustvold tustvold added the arrow Changes to the arrow crate label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document Async decoder usage (#4043) (#78) tustvold/arrow-rs
2 participants
@tustvold @waynexia