Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structured Interval Native Type #3125

Closed
tustvold opened this issue Nov 16, 2022 · 3 comments · Fixed by #5769
Closed

Structured Interval Native Type #3125

tustvold opened this issue Nov 16, 2022 · 3 comments · Fixed by #5769
Assignees
@tustvold
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

Placeholder needs fleshing out

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently interval types are represented as single primitive i64, i128, etc... This is despite them being composite types. The result is error prone, leading to incorrect overflow, parsing, etc... behaviour

Describe the solution you'd like

I would like to use a structured type as the native type for interval arrays, in a similae vein to the custom i256 type

Describe alternatives you've considered

Additional context
@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Nov 16, 2022
@tustvold
Copy link
Contributor Author

This may fall out of the arrow2 integration work #1176

@tustvold tustvold closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2023
@tustvold tustvold reopened this Apr 24, 2024
@tustvold tustvold mentioned this issue Apr 24, 2024
Closed
@tustvold
Copy link
Contributor Author

This is blocked on #4733 as the kernels based around ToPrimitive will not work with a custom type

@tustvold tustvold self-assigned this May 15, 2024
tustvold added a commit to tustvold/arrow-rs that referenced this issue May 15, 2024
@tustvold
Structured interval type (apache#3125) (apache#5654)
2dfa137
@tustvold tustvold mentioned this issue May 15, 2024
Merged
tustvold added a commit to tustvold/arrow-rs that referenced this issue May 15, 2024
@tustvold
Structured interval type (apache#3125) (apache#5654)
f5a5127
tustvold added a commit to tustvold/arrow-rs that referenced this issue May 15, 2024
@tustvold
Structured interval type (apache#3125) (apache#5654)
30ae103
tustvold added a commit to tustvold/arrow-rs that referenced this issue May 15, 2024
@tustvold
Structured interval type (apache#3125) (apache#5654)
416958a
@alamb
Copy link
Contributor

alamb commented May 17, 2024

Proposed PR #5769

tustvold added a commit that referenced this issue May 20, 2024
@tustvold
Structured interval types for IntervalMonthDayNano or `IntervalDayT…
cf59b6c 
…ime` (#3125) (#5654) (#5769)

* Structured interval type (#3125) (#5654)

* Update integration-test

* Fix 32-bit build

* Review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tustvold tustvold

Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
2 participants
@alamb @tustvold