We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Buffer::count_set_bits is easy to incorrectly use, as Buffer does not know its accurate length in bits, only in bytes.
Buffer::count_set_bits
Buffer
This led to #3061
Describe the solution you'd like
I would like to deprecate Buffer::count_set_bits in favour of Buffer::count_set_bits_offset which is less easy to accidentally misuse.
Buffer::count_set_bits_offset
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered:
Looks good to me. I think mostly we care about count_set_bits_offset, not count_set_bits.
count_set_bits_offset
count_set_bits
Sorry, something went wrong.
Deprecate Buffer::count_set_bits (apache#3067)
8f83a66
Deprecate Buffer::count_set_bits (#3067) (#3071)
c027c70
* Deprecate Buffer::count_set_bits (#3067) * Format
label_issue.py automatically added labels {'arrow'} from #3062
label_issue.py
Successfully merging a pull request may close this issue.
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Buffer::count_set_bits
is easy to incorrectly use, asBuffer
does not know its accurate length in bits, only in bytes.This led to #3061
Describe the solution you'd like
I would like to deprecate
Buffer::count_set_bits
in favour ofBuffer::count_set_bits_offset
which is less easy to accidentally misuse.Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered: