Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make JSON support Optional via Feature Flag #2300

Closed
tustvold opened this issue Aug 3, 2022 · 0 comments · Fixed by #2601
Closed

Make JSON support Optional via Feature Flag #2300

tustvold opened this issue Aug 3, 2022 · 0 comments · Fixed by #2601
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

tustvold commented Aug 3, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently arrow-rs always compiles the JSON related logic, not only does this always bring some non-trivial dependencies, but is itself a non-trivial amount of code

Describe the solution you'd like

I would like an optional json feature, much like there are already feature flags for ipc and csv.

Describe alternatives you've considered

We could not do this

Additional context

#2296
@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Aug 3, 2022
@tustvold tustvold mentioned this issue Aug 26, 2022
Closed
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 26, 2022
@tustvold
Move JsonSerializable to json module (apache#2300)
6e4db9f
@tustvold tustvold mentioned this issue Aug 26, 2022
Merged
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 26, 2022
@tustvold
Move JsonSerializable to json module (apache#2300)
2382f3d
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 26, 2022
@tustvold
Move JsonSerializable to json module (apache#2300)
d5e6bc9
tustvold added a commit that referenced this issue Aug 27, 2022
@tustvold
Move JsonSerializable to json module (#2300) (#2595)
ff81dee
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 27, 2022
@tustvold
Split out integration test plumbing (apache#2594) (apache#2300)
e3fb3a1
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 27, 2022
@tustvold
Split out integration test plumbing (apache#2594) (apache#2300)
426065a
@tustvold tustvold mentioned this issue Aug 27, 2022
Merged
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 27, 2022
@tustvold
Split out integration test plumbing (apache#2594) (apache#2300)
ea14618
tustvold added a commit that referenced this issue Aug 28, 2022
@tustvold
Split out integration test plumbing (#2594) (#2300) (#2598)
c6e7680 
* Split out integration test plumbing (#2594) (#2300)

* Fix RAT
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 28, 2022
@tustvold
Add json feature (apache#2300)
e23ba78
@tustvold tustvold mentioned this issue Aug 28, 2022
Merged
@alamb alamb added the arrow Changes to the arrow crate label Sep 1, 2022
tustvold added a commit that referenced this issue Sep 1, 2022
@tustvold
Make JSON support optional via a feature flag (#2300) (#2601)
b792ff7 
* Add json feature (#2300)

* Fix parquet

* Add json feature to wasm build

* Update README
This was referenced Sep 13, 2022
Closed
Merged
@tustvold tustvold mentioned this issue Sep 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make JSON support optional via a feature flag (#2300) tustvold/arrow-rs
2 participants
@alamb @tustvold