Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support skip_rep_levels in ColumnLevelDecoder #2108

Closed
Ted-Jiang opened this issue Jul 19, 2022 · 3 comments · Fixed by #2999
Closed

Support skip_rep_levels in ColumnLevelDecoder #2108

Ted-Jiang opened this issue Jul 19, 2022 · 3 comments · Fixed by #2999
Labels
enhancement Any new improvement worthy of a entry in the changelog help wanted

Comments

@Ted-Jiang
Copy link
Member

Ted-Jiang commented Jul 19, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

pub trait RepetitionLevelDecoder: ColumnLevelDecoder {
/// Skips over repetition level corresponding to `num_records` records, where a record
/// is delimited by a repetition level of 0
///
/// Returns the number of records skipped, and the number of levels skipped
fn skip_rep_levels(&mut self, num_records: usize) -> Result<(usize, usize)>;
}

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@Ted-Jiang Ted-Jiang added the enhancement Any new improvement worthy of a entry in the changelog label Jul 19, 2022
@Ted-Jiang
Copy link
Member Author

Ted-Jiang commented Jul 19, 2022

@tustvold @alamb please add help wanted 😊

@tustvold
Copy link
Contributor

tustvold commented Nov 1, 2022

Why is this closed?

@Ted-Jiang
Copy link
Member Author

 fn skip_rep_levels(&mut self, _num_records: usize) -> Result<(usize, usize)> {
        Err(nyi_err!("https://github.com/apache/arrow-rs/issues/1792"))
    }

Not finished reopen it.😂

@Ted-Jiang Ted-Jiang reopened this Nov 2, 2022
tustvold added a commit that referenced this issue Nov 5, 2022
* Add buffer to ColumnLevelDecoderImpl (#2108)

* Implement skip_rep_levels

* Add integration test

* Clippy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog help wanted
Projects
None yet
2 participants