Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BufferBuilder in parquet instead of custom ScalarBuffer #1849

Closed
tustvold opened this issue Jun 11, 2022 · 0 comments · Fixed by #5178
Closed

Use BufferBuilder in parquet instead of custom ScalarBuffer #1849

tustvold opened this issue Jun 11, 2022 · 0 comments · Fixed by #5178
Assignees
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

The existence of the custom ScalarBuffer in the parquet crate is primarily because I wasn't aware of BufferBuilder at the time I wrote it. With some relatively minor additions to BufferBuilder the parquet crate could make use of it.

Describe the solution you'd like

  • Add a doc comment pointing users of MutableBuffer to BufferBuilder
  • Add as_slice, as_mut_slice and resize APIs to BufferBuilder
  • Create dedicated BooleanArrayReader for parquet, as bool: ArrowNativeType
  • Remove parquet's ScalarBuffer

Describe alternatives you've considered

We could not do this

Additional context

#1820 added a different ScalarBuffer abstraction to arrow, this is a bit of a confusing situation and we should just remove the version from parquet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant