Skip to content

Commit

Permalink
remove --src-dir
Browse files Browse the repository at this point in the history
  • Loading branch information
dianaclarke committed Feb 9, 2022
1 parent ce8b4d0 commit b22e96f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion conbench/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ $ cd ~/arrow-rs/conbench/
$ conda create -y -n conbench python=3.9
$ conda activate conbench
(conbench) $ pip install -r requirements.txt
(conbench) $ conbench arrow-rs --src-dir=/Users/diana/workspace/arrow-rs
(conbench) $ conbench arrow-rs
```

## Example output
Expand Down
5 changes: 2 additions & 3 deletions conbench/_criterion.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,10 @@ def _execute_command(command):


class CriterionBenchmark(conbench.runner.Benchmark):
external, iterations = True, None
options = {"src_dir": {"type": str}}
external = True

def run(self, **kwargs):
src_dir = kwargs["src_dir"]
os.path.join(os.getcwd(), "..")
self._cargo_bench(src_dir)
results = _read_results(src_dir)
for suite in results:
Expand Down

0 comments on commit b22e96f

Please sign in to comment.