Skip to content

Commit

Permalink
apply reviewer suggestions
Browse files Browse the repository at this point in the history
Co-authored-by: Andrew Lamb <[email protected]>
  • Loading branch information
jp0317 and alamb authored Jan 10, 2025
1 parent d423b01 commit 907a43d
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,11 @@ Planned Release Schedule

In general, use panics for bad states that are unreachable, unrecoverable or harmful.
For those caused by invalid user input, however, we prefer to report that invalidity
gracefully as an error result instead of panicking. Note that it still makes sense
to have some panic/assert statements, given that the invalidity of user input is
examined and reported as errors first.
gracefully as an error result instead of panicking. In general, invalid input should result
in an `Error` as soon as possible. It *is* ok for code paths after validation to assume validation has
already occurred and and panic if not. See [this ticket] for more nuances.

[this ticket]: https://github.com/apache/arrow-rs/issues/6737

### Deprecation Guidelines

Expand Down

0 comments on commit 907a43d

Please sign in to comment.