fix comment

object_store/src/lib.rs

@@ -1064,8 +1064,6 @@ pub enum PutMode {
     /// Perform an atomic write operation if the current version of the object matches the
     /// provided [`UpdateVersion`], returning [`Error::Precondition`] otherwise
     Update(UpdateVersion),
-    /// Only for Mounted path, drop the file before renaming so that the file will upload.
-    OverwriteUnsafe,
 }
 
 /// Uniquely identifies a version of an object to update

object_store/src/local.rs

@@ -341,10 +341,13 @@ impl ObjectStore for LocalFileSystem {
 
             let err = match file.write_all(&bytes) {
                 Ok(_) => match opts.mode {
-                    PutMode::Overwrite => match std::fs::rename(&staging_path, &path) {
-                        Ok(_) => None,
-                        Err(source) => Some(Error::UnableToRenameFile { source }),
-                    },
+                    PutMode::Overwrite => {
+                        std::mem::drop(file);
+                        match std::fs::rename(&staging_path, &path) {
+                            Ok(_) => None,
+                            Err(source) => Some(Error::UnableToRenameFile { source }),
+                        }
+                    }
                     PutMode::Create => match std::fs::hard_link(&staging_path, &path) {
                         Ok(_) => {
                             let _ = std::fs::remove_file(&staging_path); // Attempt to cleanup
@@ -359,13 +362,6 @@ impl ObjectStore for LocalFileSystem {
                         },
                     },
                     PutMode::Update(_) => unreachable!(),
-                    PutMode::OverwriteUnsafe => {
-                        std::mem::drop(file);
-                        match std::fs::rename(&staging_path, &path) {
-                            Ok(_) => None,
-                            Err(source) => Some(Error::UnableToRenameFile { source }),
-                        }
-                    }
                 },
                 Err(source) => Some(Error::UnableToCopyDataToFile { source }),
             };

object_store/src/memory.rs

@@ -177,7 +177,6 @@ impl ObjectStore for InMemory {
             PutMode::Overwrite => storage.overwrite(location, entry),
             PutMode::Create => storage.create(location, entry)?,
             PutMode::Update(v) => storage.update(location, v, entry)?,
-            PutMode::OverwriteUnsafe => storage.overwrite(location, entry),
         }
         storage.next_etag += 1;