Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore empty (but present) union validity bitmaps from before 1.0 #630

Merged
merged 1 commit into from
Sep 20, 2024
Merged

fix: ignore empty (but present) union validity bitmaps from before 1.0 #630

merged 1 commit into from
Sep 20, 2024

Conversation

bkietz
Copy link
Member

@bkietz bkietz commented Sep 20, 2024

For metadata versions before V5, ignore the extra validity bitmap. If the bitmap is non-empty, we raise an error (which is the same bail used in arrow-C++ and -java).

@bkietz bkietz requested a review from paleolimbot September 20, 2024 19:40
paleolimbot
paleolimbot approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Again, we should maybe eventually remove this complexity (but getting the integration tests passing is a better near-term goal).

@paleolimbot paleolimbot merged commit 57acfbe into apache:main Sep 20, 2024
34 checks passed
@bkietz bkietz deleted the allow-union-nulls branch September 20, 2024 21:53
@paleolimbot paleolimbot added this to the nanoarrow 0.6.0 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paleolimbot paleolimbot paleolimbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
nanoarrow 0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bkietz @paleolimbot