Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Fix build and test of nanoarrow on centos7 and s390x #576

Merged
merged 5 commits into from
Aug 6, 2024
Merged

fix(ci): Fix build and test of nanoarrow on centos7 and s390x #576

merged 5 commits into from
Aug 6, 2024

Conversation

paleolimbot
Copy link
Member

@paleolimbot paleolimbot commented Aug 5, 2024 •
edited
Loading

Noted in the weekly verification run: https://github.com/apache/arrow-nanoarrow/actions/runs/10232042714/job/28308701770

I think there were a three issues:

Reproducible via:

export NANOARROW_PLATFORM=centos7
docker compose run -e TEST_PYTHON=0 -e TEST_R=0 --rm verify
export NANOARROW_PLATFORM=alpine
export NANOARROW_ARCH=s390x
docker compose run -e TEST_DEFAULT=0 -e TEST_C=1 --rm verify

@paleolimbot paleolimbot force-pushed the ci-fix-centos7-ipc-changes branch from 2a49e43 to b10de44 Compare August 5, 2024 18:54
@paleolimbot paleolimbot marked this pull request as ready for review August 6, 2024 12:51
@paleolimbot paleolimbot requested a review from bkietz August 6, 2024 12:51
@paleolimbot paleolimbot changed the title fix(ci): Fix build and test of nanoarrow on centos7 fix(ci): Fix build and test of nanoarrow on centos7 and s390x Aug 6, 2024
bkietz
bkietz approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@bkietz bkietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs a rebase

src/nanoarrow/ipc/encoder.c Outdated
@@ -395,7 +395,11 @@ ArrowErrorCode ArrowIpcEncoderEncodeSchema(struct ArrowIpcEncoder* encoder,

FLATCC_RETURN_UNLESS_0(Message_header_Schema_start(builder));

FLATCC_RETURN_UNLESS_0(Schema_endianness_add(builder, ArrowIpcSystemEndianness()));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮‍💨

@paleolimbot paleolimbot merged commit 738b821 into apache:main Aug 6, 2024
46 checks passed
@paleolimbot paleolimbot deleted the ci-fix-centos7-ipc-changes branch August 8, 2024 00:04
@paleolimbot paleolimbot added this to the nanoarrow 0.6.0 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkietz bkietz bkietz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
nanoarrow 0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@paleolimbot @bkietz