feat: Add IPC schema encoding #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paleolimbot
approved these changes
Jul 26, 2024
src/nanoarrow/ipc/decoder_test.cc
Outdated
| n = ArrowSchemaToString(schema, out.data(), out.size(), /*recursive=*/true); | ||
| } | ||
| return out; | ||
| } |
There was a problem hiding this comment.
This is nanoarrow's fault for not having a proper schema comparison; however, this is technically not comparing metadata or flags. We could tack those on to this output string or punt to a better schema comparison (your call!).
There was a problem hiding this comment.
For now, I'll just add the metadata to the string.
bkietz
force-pushed
the
ipc-schema-encoding
branch
from
2e55b7b to
ad96b40
Compare
paleolimbot
approved these changes
Jul 30, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #555 (review)