refactor: Separate components into folders under src/nanoarrow #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assignUser
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of files in src/nanoarrow had accumulated quite a bit, which wasn't exactly a problem, but the files did have confusingly verbose names for historical reasons (mostly that the IPC and Device libraries originated elsewhere). This PR moves the
nanoarrowtarget sources tosrc/nanoarrow/common, thenanoarrow_ipctarget sources tosrc/nanoarrow/ipc, thenanoarrow_devicetarget sources tosrc/nanoarrow/device, and the tests for the testing helpers tosrc/nanoarrow/testing(in the future this will/should be ananoarrow_testingtarget).I did leave the user-facing headers in src/nanoarrow, which makes a slightly cleaner transition between the "bundled" and CMake/Meson subproject builds (i.e., one always just does
#include "nanoarrow/nanoarrow.h")