-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Add wrappers around callbacks to improve syntax and debuggability #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
==========================================
- Coverage 88.15% 88.12% -0.03%
==========================================
Files 73 72 -1
Lines 11529 11579 +50
==========================================
+ Hits 10163 10204 +41
- Misses 1366 1375 +9 ☔ View full report in Codecov by Sentry. |
2bad164
to
2b70f9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds thin wrappers around C function pointers (like is done in Arrow C++) for Arrow C Data/Stream interface structures and uses them in all tests and internal code. The motivation for this was:
x.release(&x)
is a tiny bit verbose and involves specifyingx
twiceget_last_error
was non-NULL, which is not true). The wrappers let you doNANOARROW_RETURN_NOT_OK(ArrowArrayStreamGetNext(stream, out, error))
which better integrates into the nanoarrow error handling pattern.The changes are: