GH-11: Add test CI: macOS #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
force-pushed
the
ci-macos
branch
6 times, most recently
from
c159498 to
f4f2ddc
Compare
|
Before we can truly claim that the CI is working, we need to update the package path of the We can probably leverage the same |
|
OK. How about #88? |
Fix apacheGH-11 This part: https://github.com/apache/arrow/blob/58415d1fac50cb829b3dcf08526033d6db8c30db/.github/workflows/go.yml#L305-L360 This also imports `ci/scripts/go_{build,test}.sh` from apache/arrow. This also introduce ShellCheck and shfmt with pre-commit. This also adds apache/arrow-testing and apache/parquet-testing submodules.
|
Passed: https://github.com/kou/arrow-go/actions/runs/10745815085 I'll merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix GH-11
This part:
https://github.com/apache/arrow/blob/58415d1fac50cb829b3dcf08526033d6db8c30db/.github/workflows/go.yml#L305-L360
This also imports
ci/scripts/go_{build,test}.shfrom apache/arrow.This also introduce ShellCheck and shfmt with pre-commit.
This also adds apache/arrow-testing and apache/parquet-testing submodules.