fix(internal/json): add arrow_json_stdlib build tag #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddtreece
force-pushed
the
toddtreece/json-stdlib
branch
from
8de74c2 to
c812146
Compare
|
We mostly use |
|
@zeroshade sounds good, thanks! i will continue trying to get the |
toddtreece
force-pushed
the
toddtreece/json-stdlib
branch
2 times, most recently
from
608feff to
0171ae5
Compare
toddtreece
force-pushed
the
toddtreece/json-stdlib
branch
from
0171ae5 to
4291143
Compare
|
@zeroshade it looks like maybe you pushed a fix for the failing mac OS checks, so i rebased this against main |
zeroshade
approved these changes
Dec 4, 2024
This was referenced Dec 6, 2024
zeroshade
pushed a commit
that referenced
this pull request
Dec 12, 2024
### Rationale for this change A follow up to #199 (comment) > i will continue trying to get the go-json PR merged, and if i do, i'll open another PR to update the dependency here. ### What changes are included in this PR? Bumps go-json dependency to include changes from goccy/go-json#490 ### Are these changes tested? I am assuming CI tests should cover this. ### Are there any user-facing changes? No
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Grafana and Grafana plugins both use arrow-go, but do not use arrow's
internal/json. A decent amount of used heap is initialized by https://github.com/goccy/go-json, so it would be useful to be able to prevent the initialization.The example below shows that 60% of this heap profile in a Grafana plugin is used by
go-json's encoder & decoder packages.I have submitted a PR to go-json to switch to lazy initialization (additional details in the PR), but I am having a hard time getting a response from the maintainer, so am attempting a different approach to the problem with this PR.
What changes are included in this PR?
Adds
arrow_json_stdlibbuild tag so that it's possible to switch toencoding/jsonand avoid the overhead of https://github.com/goccy/go-json.Are these changes tested?
I tested this locally, but I can add coverage if this seems like an acceptable approach.
Are there any user-facing changes?