Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(csharp/src/Drivers/Apache): detect sever error when polling for response #2355

Merged
merged 1 commit into from
Dec 7, 2024
Merged

fix(csharp/src/Drivers/Apache): detect sever error when polling for response #2355

merged 1 commit into from
Dec 7, 2024

Conversation

birschick-bq
Copy link
Contributor

Checks the return status when polling for response.

  • Must be in the FINISHED_STATE. Other states are invalid after polling.
  • Difficult to write tests for this without "abusing" the server to invoke a server error.

@github-actions github-actions bot added this to the ADBC Libraries 16 milestone Dec 7, 2024
CurtHagenlocher
CurtHagenlocher approved these changes Dec 7, 2024
View reviewed changes
Copy link
Contributor

@CurtHagenlocher CurtHagenlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@CurtHagenlocher CurtHagenlocher merged commit 7d2b719 into apache:main Dec 7, 2024
8 checks passed
@birschick-bq birschick-bq deleted the dev/birschick-bq/fix-poll-error branch December 10, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CurtHagenlocher CurtHagenlocher CurtHagenlocher approved these changes

@lidavidm lidavidm Awaiting requested review from lidavidm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 16
Development

Successfully merging this pull request may close these issues.
2 participants
@birschick-bq @CurtHagenlocher