feat(csharp/src/Client): parse custom properties from connection string #2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birschick-bq
reviewed
Dec 5, 2024
| CommandTimeoutValue = ConnectionStringParser.ParseTimeoutValue(paramValue); | ||
| break; | ||
| case ConnectionStringKeywords.ConnectionTimeout: | ||
| this.connectionTimeoutValue = ConnectionStringParser.ParseTimeoutValue(paramValue); |
There was a problem hiding this comment.
Since this has no effect on the underlying ADBC driver, is this to help synchronize the value with the driver?
There was a problem hiding this comment.
You are right in that it doesn't do much. The initial driver value would get set when the properties are passed in for the driver. However, ConnectionTimeout is only a get call, and it would differ from the actual value that was passed in. That said, maybe this could be better if you have an idea.
There was a problem hiding this comment.
I made a slight tweak to it so that it will set the property on the driver if it is passed in and it will also have a matching get value in that case.
birschick-bq
reviewed
Dec 5, 2024
|
@davidhcoe - Everything else looks good to me. |
Co-authored-by: Bruce Irschick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2312 to add parsing of the timeout values and other custom properties like StructBehavior and DecimalBehavior from the connection string.