Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(go/adbc/driver/bigquery): set default project and dataset for new statements #2342

Merged
merged 1 commit into from
Dec 7, 2024
Merged

fix(go/adbc/driver/bigquery): set default project and dataset for new statements #2342

merged 1 commit into from
Dec 7, 2024

Conversation

cocoa-xu
Copy link
Contributor

@cocoa-xu cocoa-xu commented Dec 2, 2024

This PR sets DefaultProjectID and DefaultDatasetID for new adbc.Statement to the corresponding value in the adbc.Connection.

@cocoa-xu cocoa-xu requested a review from zeroshade as a code owner December 2, 2024 12:32
@github-actions github-actions bot modified the milestone: ADBC Libraries 16 Dec 2, 2024
@jonatanklosko jonatanklosko mentioned this pull request Dec 3, 2024
Open
@lidavidm lidavidm merged commit e6bb104 into apache:main Dec 7, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

@josevalim josevalim josevalim approved these changes

@zeroshade zeroshade Awaiting requested review from zeroshade zeroshade is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 16
Development

Successfully merging this pull request may close these issues.
3 participants
@cocoa-xu @josevalim @lidavidm