-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add loki-logger plugin #9399
Conversation
|
||
|
||
=== TEST 4: check loki log | ||
--- config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can write a public function to query the log
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@soulbird please help to check
@bzp2010 Instead of fetching the loki logs in our function in the tests, what if we use https://vector.dev/docs/reference/configuration/sinks/loki/ ? This is being used in tcp-logger, and there are other pull requests to add the same for other loggers as well. What do you think? |
@Sn0rt please help to review |
LGTM, could you provide the chinese doc? |
Since I'm busy with some other things, I can't afford to finish the Chinese document for now. But I think if the code and test of this PR are fine, we can merge it first, and once it is merged, I will create an issue and mark it as the good first issue, expecting some potential contributor to help finish it. |
Hi, @Revolyssup. I'd like to understand where this essentially lies in terms of consideration. I don't know much about vectors, but I think it makes sense to track upstream (i.e. Grafana Loki itself). If we use vector to receive logs, we may have to wait for it once the protocol is upgraded. |
@Revolyssup please help to check |
Please remember to create a issue |
Description
Create the
loki-logger
plugin.Add: #9072
Checklist