Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin): fix wrong http code for patch method #8855

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

An-DJ
Copy link
Contributor

@An-DJ An-DJ commented Feb 14, 2023

Description

The default http code of patch method to admin.resources is 201. It should be corrected to 200.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

soulbird
soulbird previously approved these changes Feb 15, 2023
@juzhiyuan juzhiyuan requested a review from bzp2010 February 15, 2023 01:27
tokers
tokers previously approved these changes Feb 15, 2023
apisix/core/etcd.lua Outdated Show resolved Hide resolved
@An-DJ An-DJ dismissed stale reviews from tokers and soulbird via cad8580 February 15, 2023 06:58
@spacewander spacewander merged commit 6160667 into apache:master Feb 17, 2023
hongbinhsu added a commit to fitphp/apix that referenced this pull request Feb 23, 2023
* upstream/master:
  fix: limit count plugin conf parameter undefined error (apache#8902)
  chore: remove duplicate kubernetes test case (apache#8882)
  feat: add 'range_id' algorithm for 'request-id' plugin (apache#8790)
  chore(error-log-logger): add kafka meta_refresh_interval (apache#8821)
  chore(deps): bump golang.org/x/net from 0.2.0 to 0.7.0 in /t/grpc_server_example (apache#8881)
  docs: Update getting-started.md (apache#8763)
  fix(admin): fix wrong http code for patch method (apache#8855)
  feat: stream subsystem support tars service discovery (apache#8826)
  feat(ci): implement image caching to reduce ci build time. (apache#8735)
  feat(admin): add head method support to /apisix/admin (apache#8752)
  feat: opentelemetry plugin config collector.address support specify https scheme (apache#8823)
  fix: add admin schema to control_plane config (apache#8809)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants