fix: fix fetch all service info from consul

[Fabriceli]

Description

Fixes # (issue)
As I mentioned in the email: https://lists.apache.org/thread/x0ksxx003tgqy4833vmsyq1mwwyc6wz7

Checklist

• I have explained the need for this PR and the problem it solves
• I have explained the changes or the new features added to this PR
• I have added tests corresponding to this change
• I have updated the documentation to reflect this change
• I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

[Fabriceli]

@spacewander Please take a look at this PR, thanks

[spacewander]

#8651 (comment)
It seems there are still indentation issues. Some places use 8-spaces indentation instead of 4.

[Fabriceli]

#8651 (comment) It seems there are still indentation issues. Some places use 8-spaces indentation instead of 4.

I checked the code and make lint cant get WARN and ERROR, could you give some hint about this? I break a long code line to multiple lines, it will be made like follow by default:

log.error("connect consul: ", consul_server.consul_server_url,
        ", by service url: ", svc_url, ", with error: ", error_info)

[spacewander]

#8651 (comment) It seems there are still indentation issues. Some places use 8-spaces indentation instead of 4.

I checked the code and make lint cant get WARN and ERROR, could you give some hint about this? I break a long code line to multiple lines, it will be made like follow by default:

log.error("connect consul: ", consul_server.consul_server_url,
        ", by service url: ", svc_url, ", with error: ", error_info)

The style guide tells us that we need to use 4-spaces indentation: https://github.com/apache/apisix/blob/master/CODE_STYLE.md#indentation

Some of the newly added code use 8-spaces indentation.

Another acceptable indentation is aligning the '(', like:

log.error("connect consul: ", consul_server.consul_server_url,
          ", by service url: ", svc_url, ", with error: ", error_info)

It is widely used in the APISIX source code.

I have tried several lints/fmtters. Unfortunately, they can't handle the second case. Therefore, so far we don't have an automatical mechanism to detect the indentation issue.

[Fabriceli]

#8651 (comment) It seems there are still indentation issues. Some places use 8-spaces indentation instead of 4.

I checked the code and make lint cant get WARN and ERROR, could you give some hint about this? I break a long code line to multiple lines, it will be made like follow by default:

log.error("connect consul: ", consul_server.consul_server_url,
        ", by service url: ", svc_url, ", with error: ", error_info)

The style guide tells us that we need to use 4-spaces indentation: https://github.com/apache/apisix/blob/master/CODE_STYLE.md#indentation

Some of the newly added code use 8-spaces indentation.

Another acceptable indentation is aligning the '(', like:

log.error("connect consul: ", consul_server.consul_server_url,
          ", by service url: ", svc_url, ", with error: ", error_info)

It is widely used in the APISIX source code.

I have tried several lints/fmtters. Unfortunately, they can't handle the second case. Therefore, so far we don't have an automatical mechanism to detect the indentation issue.

Done, please re-check it, thanks

[Fabriceli]

@tzssangglass could you have a look at this PR, thanks

[Fabriceli]

@spacewander Could you request another committer to do the code review for this PR, thanks