Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: adjust response format for V3 feature #7630

Merged
merged 9 commits into from
Aug 11, 2022
Merged

change: adjust response format for V3 feature #7630

merged 9 commits into from
Aug 11, 2022

Conversation

tzssangglass
Copy link
Member

Description

Fixes #7320

It is sister PR of #7366

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@tzssangglass tzssangglass marked this pull request as ready for review August 9, 2022 09:13
spacewander
spacewander previously approved these changes Aug 10, 2022
View reviewed changes
apisix/core/config_etcd.lua Show resolved Hide resolved
juzhiyuan
juzhiyuan approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked changes on md fiels and /t files, LGTM

@spacewander spacewander merged commit bda9ca8 into apache:master Aug 11, 2022
@tzssangglass tzssangglass deleted the v3_resp_format branch October 10, 2022 10:42
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request Nov 4, 2022
@tzssangglass @Liu-Junlin
change: adjust response format for V3 feature (apache#7630)
a15160d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacewander spacewander spacewander approved these changes

@juzhiyuan juzhiyuan juzhiyuan approved these changes

@soulbird soulbird Awaiting requested review from soulbird

@membphis membphis Awaiting requested review from membphis

@bzp2010 bzp2010 Awaiting requested review from bzp2010

@tokers tokers Awaiting requested review from tokers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: new API design for the Admin API
3 participants
@tzssangglass @juzhiyuan @spacewander