Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clickhouse-logger): support multi clickhouse endpoints #7517

Merged
merged 4 commits into from
Jul 28, 2022
Merged

feat(clickhouse-logger): support multi clickhouse endpoints #7517

merged 4 commits into from
Jul 28, 2022

Conversation

qizhendong1
Copy link
Contributor

@qizhendong1 qizhendong1 commented Jul 21, 2022 •
edited
Loading

Description

When the apisix load is heavy, there are many access logs, and the endpoint load of a single clickhouse is too heavy. The clickhouse-alogger plugin supports multiple endpoints to share the load.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@tzssangglass
Copy link
Member

files conflict, pls rebase the upstream master to your PR branch.

@qizhendong1 qizhendong1 force-pushed the ch branch 5 times, most recently from d79a56a to 7f2da81 Compare July 24, 2022 07:31
@qizhendong1
Copy link
Contributor Author

files conflict, pls rebase the upstream master to your PR branch.

resolved

@qizhendong1 qizhendong1 marked this pull request as ready for review July 24, 2022 07:36
@qizhendong1 qizhendong1 changed the title feat(clickhouse-logger): support multi endpoints feat(clickhouse-logger): support multi clickhouse endpoints Jul 24, 2022
spacewander
spacewander reviewed Jul 24, 2022
View reviewed changes
apisix/plugins/clickhouse-logger.lua Show resolved Hide resolved
t/plugin/clickhouse-logger.t Outdated Show resolved Hide resolved
@qizhendong1 qizhendong1 requested a review from spacewander July 25, 2022 09:23
@qizhendong1 qizhendong1 force-pushed the ch branch 2 times, most recently from 5a46205 to a42c46f Compare July 25, 2022 13:32
@qizhendong1
Copy link
Contributor Author

The test case doesn't pass.
https://github.com/apache/apisix/runs/7500977665?check_suite_focus=true#step:14:538

@qizhendong1 qizhendong1 force-pushed the ch branch 2 times, most recently from 6319543 to fb03aca Compare July 27, 2022 05:40
@spacewander spacewander merged commit f0a8355 into apache:master Jul 28, 2022
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request Nov 4, 2022
@qizhendong1 @Liu-Junlin
feat(clickhouse-logger): support multi clickhouse endpoints (apache#7517
213848b 
)
@xiaoxuanzi xiaoxuanzi mentioned this pull request Jan 4, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzssangglass tzssangglass tzssangglass approved these changes

@spacewander spacewander spacewander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qizhendong1 @tzssangglass @spacewander