Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(jwt-auth): get JWT by ctx.var.cookie_jwt instead of resty.cookie #5947

Merged
merged 3 commits into from
Dec 30, 2021
Merged

chore(jwt-auth): get JWT by ctx.var.cookie_jwt instead of resty.cookie #5947

merged 3 commits into from
Dec 30, 2021

Conversation

tzssangglass
Copy link
Member

…ookie

Signed-off-by: tzssangglass [email protected]

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@tzssangglass tzssangglass changed the title chore(jwt-auth): get JWT by ctx.var.cookie_jwt instead of use resty.c… chore(jwt-auth): get JWT by ctx.var.cookie_jwt instead of resty.cookie Dec 28, 2021
@tokers
Copy link
Contributor

tokers commented Dec 29, 2021

@tzssangglass Could you describe the reason for this or add the corresponding issue link?

@tzssangglass
Copy link
Member Author

tzssangglass commented Dec 29, 2021 •
edited
Loading

@tzssangglass Could you describe the reason for this or add the corresponding issue link?

ok, inspired by review this PR is the comments seen: #5727 (comment)

It is recommended to use ctx.var.cookie_* in the plugin to get cookies

@tzssangglass
adjust the err log level
fe1ba65 
Signed-off-by: tzssangglass <[email protected]>
tokers
tokers reviewed Dec 29, 2021
View reviewed changes
apisix/plugins/jwt-auth.lua Outdated Show resolved Hide resolved
@tzssangglass
resolve code review
35c0fcb 
Signed-off-by: tzssangglass <[email protected]>
@tzssangglass tzssangglass requested a review from tokers December 30, 2021 01:19
@spacewander spacewander merged commit 7045f97 into apache:master Dec 30, 2021
@tzssangglass tzssangglass deleted the jwt_cookie branch January 24, 2022 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacewander spacewander spacewander approved these changes

@bzp2010 bzp2010 bzp2010 approved these changes

@shuaijinchao shuaijinchao shuaijinchao approved these changes

@tokers tokers tokers approved these changes

@leslie-tsang leslie-tsang leslie-tsang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tzssangglass @tokers @spacewander @bzp2010 @shuaijinchao @leslie-tsang