-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kafka-logger): supports logging request body #5501
Changes from 8 commits
613c19e
acb54e3
fb04109
d922ffd
3e867ea
f691471
d82854c
a017631
7ea1b17
d31a5ab
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,7 @@ local log_util = require("apisix.utils.log-util") | |
local producer = require ("resty.kafka.producer") | ||
local batch_processor = require("apisix.utils.batch-processor") | ||
local plugin = require("apisix.plugin") | ||
local expr = require("resty.expr.v1") | ||
|
||
local math = math | ||
local pairs = pairs | ||
|
@@ -74,6 +75,16 @@ local schema = { | |
inactive_timeout = {type = "integer", minimum = 1, default = 5}, | ||
batch_max_size = {type = "integer", minimum = 1, default = 1000}, | ||
include_req_body = {type = "boolean", default = false}, | ||
include_req_body_expr = { | ||
type = "array", | ||
minItems = 1, | ||
items = { | ||
type = "array", | ||
items = { | ||
type = "string" | ||
} | ||
} | ||
}, | ||
-- in lua-resty-kafka, cluster_name is defined as number | ||
-- see https://github.com/doujiang24/lua-resty-kafka#new-1 | ||
cluster_name = {type = "integer", minimum = 1, default = 1}, | ||
|
@@ -98,6 +109,14 @@ local _M = { | |
|
||
|
||
function _M.check_schema(conf, schema_type) | ||
|
||
if conf.vars then | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should be |
||
local ok, err = expr.new(conf.vars) | ||
if not ok then | ||
return nil, {error_msg = "failed to validate the 'vars' expression: " .. err} | ||
end | ||
end | ||
|
||
if schema_type == core.schema.TYPE_METADATA then | ||
return core.schema.check(metadata_schema, conf) | ||
end | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1114,3 +1114,82 @@ GET /t | |
--- error_log_like eval | ||
qr/create new kafka producer instance, brokers: \[\{"port":9092,"host":"127.0.0.127"}]/ | ||
qr/failed to send data to Kafka topic: .*, brokers: \{"127.0.0.127":9092}/ | ||
|
||
|
||
|
||
=== TEST 26: set route(id: 1,include_req_body = true,include_req_body_expr = array) | ||
--- config | ||
location /t { | ||
content_by_lua_block { | ||
local t = require("lib.test_admin").test | ||
local code, body = t('/apisix/admin/routes/1', | ||
ngx.HTTP_PUT, | ||
[=[{ | ||
"plugins": { | ||
"kafka-logger": { | ||
"broker_list" : | ||
{ | ||
"127.0.0.1":9092 | ||
}, | ||
"kafka_topic" : "test2", | ||
"key" : "key1", | ||
"timeout" : 1, | ||
"include_req_body": true, | ||
"include_req_body_expr": [ | ||
[ | ||
"arg_name", | ||
"==", | ||
"qwerty" | ||
] | ||
], | ||
"batch_max_size": 1 | ||
} | ||
}, | ||
"upstream": { | ||
"nodes": { | ||
"127.0.0.1:1980": 1 | ||
}, | ||
"type": "roundrobin" | ||
}, | ||
"uri": "/hello" | ||
}]=] | ||
) | ||
if code >= 300 then | ||
ngx.status = code | ||
end | ||
ngx.say(body) | ||
} | ||
} | ||
|
||
--- request | ||
GET /t | ||
--- response_body | ||
passed | ||
--- no_error_log | ||
[error] | ||
|
||
|
||
|
||
=== TEST 27: hit route, expr eval success | ||
--- request | ||
POST /hello?name=qwerty | ||
abcdef | ||
--- response_body | ||
hello world | ||
--- no_error_log | ||
[error] | ||
--- error_log eval | ||
qr/send data to kafka: \{.*"body":"abcdef"/ | ||
--- wait: 2 | ||
|
||
|
||
|
||
=== TEST 28: hit route,expr eval fail | ||
--- request | ||
POST /hello?name=zcxv | ||
abcdef | ||
--- response_body | ||
hello world | ||
--- no_error_log eval | ||
qr/send data to kafka: \{.*"body":"abcdef"/ | ||
--- wait: 2 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Duplicate There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we can merge it, could you add a check for the expr in the
check_schema
? Like:apisix/apisix/plugins/response-rewrite.lua
Line 111 in 9b355c6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done