change: added an example of plugin. #2
Conversation
lua/apimeta/plugin.lua
Outdated
| function _M.check_args(arg, scheme) | ||
| for k, v in pairs(scheme) do | ||
| if not typeof[v](arg[k]) then | ||
| return nil, "key [" .. k .. "] should be a " .. v |
There was a problem hiding this comment.
we need to print the value of the key, which is friendly for debugging.
| } | ||
|
|
||
|
|
||
| return _M |
There was a problem hiding this comment.
need to check and add license of this file, and do we really need so many types?
| } | ||
|
|
||
|
|
||
| local _M = {VER = 0.1} |
| function _M.check_args(config) | ||
| local ok, err = plugin.check_args(config, args_schema) | ||
| if not ok then | ||
| return nil, err |
There was a problem hiding this comment.
I think return false, err is better
|
|
||
| local ok, err = _M.check_args(config) | ||
| if not ok then | ||
| return ok, err |
There was a problem hiding this comment.
we should keep the same style with https://github.com/iresty/apimeta/pull/2/files#diff-b7c0a61beccdbe9021dc64ff808f0e91R17
| local args_schema = { | ||
| i = "int", -- value list: apimeta.comm.typeof#92 | ||
| s = "string", | ||
| t = "table", |
There was a problem hiding this comment.
how to set the default value or max value or min value in the schema? I think we should use dict as value.
There was a problem hiding this comment.
for example name = { type = "string", default = 'test' }
|
|
||
|
|
||
| function _M.check_args(arg, scheme) | ||
| for k, v in pairs(scheme) do |
There was a problem hiding this comment.
pairs can not be JIT, we should avoid to use it.
There was a problem hiding this comment.
that is not a hot path, it's fine.
|
|
||
|
|
||
| local _M = { | ||
| log = log, |
There was a problem hiding this comment.
No description provided.