Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support built-in variables in response_headers in mocking plugin #10872

Merged
merged 5 commits into from
Jan 31, 2024
Merged

feat: support built-in variables in response_headers in mocking plugin #10872

merged 5 commits into from
Jan 31, 2024

Conversation

MonkeyDLufy
Copy link
Contributor

@MonkeyDLufy MonkeyDLufy commented Jan 29, 2024 •
edited
Loading

Description

support built-in variables in response_headers in mocking plugin

Fixes #10868

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@MonkeyDLufy MonkeyDLufy changed the title feat: support built-in variables in response_headers in mocking plugin #10868 feat: support built-in variables in response_headers in mocking plugin Jan 29, 2024
@MonkeyDLufy
Copy link
Contributor Author

@shreemaan-abhishek hi, did I handle it correctly? Is there anything else I need to do?

@shreemaan-abhishek
Copy link
Contributor

Good job, can you add test cases as well?

@MonkeyDLufy
Copy link
Contributor Author

test cases are commited.

@shreemaan-abhishek shreemaan-abhishek merged commit 43a567c into apache:master Jan 31, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smileby smileby smileby approved these changes

@moonming moonming moonming approved these changes

@shreemaan-abhishek shreemaan-abhishek Awaiting requested review from shreemaan-abhishek

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: support built-in variables in response_headers in mocking plugin
4 participants
@MonkeyDLufy @shreemaan-abhishek @moonming @smileby